Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direction ids property for workshop #1623

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Direction ids property for workshop #1623

merged 5 commits into from
Sep 2, 2022

Conversation

litvinets
Copy link
Contributor

directionsId was replaced with directionIds

@litvinets litvinets requested a review from DmyMi September 2, 2022 10:31
@DmyMi DmyMi merged commit 5015933 into develop Sep 2, 2022
@DmyMi DmyMi deleted the directionIds branch September 2, 2022 10:33
DmyMi added a commit that referenced this pull request Apr 20, 2023
* Form hot fix (#1572)

* Update create-photo-form.component.ts

* form hot fix

* revert

* Update workshop-card.component.spec.ts

* admin fix

* Update navigation-bar.ts

* Get Personal info according to the user role (#1579)

* personalInfoRole

* personal info user role

* Update role.ts

* fix

* fix

* commt

* fix

* test fix

* test fix

* Update application-card.component.spec.ts

* Update application-card.component.spec.ts

* Update application-card.component.spec.ts

* fix

* Oi#1535 (#1576)

* added delete functionality

* added block functional

* added paginator for ministry Admin

* paginator update

* fixed test

* fix

* fi

* fixed delete request

* fix

* after review

* after review

* [Workshop] - open closed requirement to workshop Second PR #1485 (#1565)

* fixed conflicts

* fixed

* fixed by comments and fix conflicts

* conflict fix

* comment fix

* styles fix

* Update workshop-card.component.html

* Update workshop-card.component.ts

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* upgraded accordance directions with icons (#1585)

*Fixed icon id mismatch

*Removed duplicate icon

* Feature/ys update provider table #1540 (#1575)

* Fixex alignment for navigation bar arrows (#1586)

*Added properties for nav arrow alignment

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Workshop fixes (#1588)

* ownership type

* Update info-status.component.scss

* Update child.model.ts

* Update create-about-form.component.spec.ts

* Update admins.component.spec.ts

* Main page loading (#1590)

* fix

* main page loader fix

* debugger removed

* progress bar

* fix header

* style fix

* progress bar

* Update registration.state.ts

* Update registration.state.ts

* test fix

* Get codification city by user coordinates (#1593)

* get city by coordinates

* confirm city style

* Create Workshop Address - address can be populated from the map (#1595)

* commit

* set single marker

* final changes

* fix

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>

* Removed console.log from code (#1596)

* removed all console.log commands from code

* [Support/ LawsAndRegulations/ AboutPortal] - no info displaying (#1591)

* Updated display of noinfo message

* Added a app-no-result-card component to display a message

*Added new value NoResultTitle

*Removed css property that caused info to overlap breadcrumbs

* Updated tests declarations

* Returning a deleted photo and code refactoring

*Returned the deleted photo to the about, support and rules pages

*Added a removed css property that exposed information under the photo

*Changed the variable name to be more clear and moved it to the top.

* Returned deleted console.log (#1598)

* reverse geoconding (#1601)

* #1510 Strict Filtering (#1600)

* done

* test fix

* comment

* Updated visibility of input data in input (#1597)

*Moved opacity property from input to placeholder

* [Mobile-view] - main page, result-page (#1602)

* Fixed white bar on the right

*Added wrapping elements in the footer

*Fixed the width of elements that created a white bar

* Fixed incorrect display city-confirmation modal

*Modal window centered for the mobile view

*Returned triangle and rounded borders for the mobile view

*Changed width from 340px to 300px for full display at screen width 320px

* #1545 child for admins (#1599)

* model

* tab

* fix

* done

* fix

* fix

* search

* tooltip + role +search

* comment

* test

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Other Provider Workshops (#1605)

* otehr provider workshops

* otehr provider workshops

* map sync with codeficator search (#1608)

* Update user-workshop.service.ts (#1609)

* Update Achievements (#1614)

* provider state refactor achievments

* edit mode

* achievments

* dirty form

* test fix

* Update achievement-card.component.spec.ts

* Update create-achievement.component.html

* Update create-workshop-address.component.ts

* Update navigation-bar.ts

* Update navigation-bar.ts

* Update achievement.model.ts

* Revert "Update navigation-bar.ts"

This reverts commit cec9f74a2f5da09ee161ac570767a02a5dd3f4fe.

* [TopDirections/ GetDirections] - display amount of workshops for every top direction (#1612)

* display amount of workshops for every top direction

* fix

* fix

* fixed hover

* align

* cursor css

* fix test

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Update achievement-card.component.scss (#1615)

* Achiv reset (#1619)

* Update achievement-card.component.scss

* fix

* general fix

* Provider Workshop for Personal Cabinet (#1620)

* refactroing

* test fix

* Update workshop-card.component.html

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>

* Fixed broken search from main page (#1618)

* Added a command to clear the input when going to the main page

* Replaced SetSearchQueryValue command with GetFilteredWorkshops

( Due to the filtering call in the method that moves to the result page, I see no reason to call it again )

* Fav fix (#1622)

* Merge branch 'develop' into Issue-#1425-Search-bug

* fix

* FIX

* commit (#1623)

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>

* Update workshop-card.component.scss (#1626)

* Update result.component.scss (#1629)

* Removed age limitation (#1621)

* Removed maximum age limit for members

* Fixed adding child without social group (#1628)

*Added a new constant for institutionStatusId. Previously, the social group constant was used for this variable.

* Corrected the decision after discussion

* Removed constant for social groups

* Set default value for social group without using constant

* fixed bug (#1633)

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [GetTopDirections] - update request with city filtration (#1634)

* added params on Direction Statistic

* fix

* fixed

* add webservers buildpack (#1639)

* hotfix build config

* fixed direction in Найпопулярніші напрямки (#1638)

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>

* #1328 History of changes (#1637)

* add filters

* fix tests

* update imports

* add tests

Co-authored-by: Anastasiia Derkach <aderk@softserveinc.com>

* Issue #1631 fix height filter (#1635)

* Fixed incorrect display of the filter list

* Added property to fix wrong calculation of list height and width

* Updated margin-left for search result

* Updated search result margin-left so it doesn't get covered by filters

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Removed "City" as a query parameter for GetWorkshop (#1651)

* Update app-workshops.service.ts

* Update workshop-map-view-list.component.scss

* [Notifications] Link in the notification leads to 404 page #1624 (#1649)

* fixed router

* fix

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Fixet NPA in menu (#1650)

Fixet NPA in menu

* [Achievements] - add tooltip on achievement card, when the achievement title is not fully displayed (#1653)

* added tooltip on achivment card

* added one import

* [Notifications] - handle new type of notifications #1625 (#1648)

* add notification

* added notifcation text

* create enum, update Notification model

* fix

* fix after rewie

* parent state refactroing (#1655)

* [MinistryAdmin] - Update/Delete (#1643)

* create service and store Ministry Admin update

* added update functional

* fix

* fix

* finished update functionality

* fix

* fixed

* remove override

* some fix after review

* fix

* some change

* added spacing

* fixed Update State

* [Application Block/Unblock] - status change refactoring, loading fix (#1658)

* block unblock get provider application fix

* Update application-list.scss

* map view (#1667)

* "edit button" aligment AC#1656 (#1670)

* edit button aligment

* Fixed button edit button aligment

* Fixed notification icon topbar AC#1657 (#1671)

* Fixed notification icon topbar

* Update notifications.component.scss

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Create-workshop-map] - fix (#1675)

* fix

* fix

* Fix lint errors across project (#1673)

* fix typos across project

* fix lint errors

* fix scss flex-start warnings

* move out filter state interface

Co-authored-by: Taras Yaremkiv <tyare@softserveinc.com>

* Issue#1607 columns change width (#1674)

*Added directive for table

*Added component for stretch cell

* Connected functionality to tables

* Update workshop-map-view-list.component.ts (#1677)

* [ProviderAdmin/Deputy] - add update functionality (#1681)

* Added  Update Provider Admin

* removed imports which not use

* fixed test

* simplified the code

* fixed navBarTitle (#1684)

* Fixed styles info prompt about statuses in the mobile version the text about statuses is cut off #1513 (#1687)

Done!

* Issue#1570 get children list get workshop list (#1692)

#1570 
*Added truncated model to get shortened data about children and workshops.

*The truncated model was built into the work of the parent's cabinet

*The truncated model was built into the work of the provider's cabinet

* [Create/Update provider] - form fix, image form control is hidden, validation form fix (#1693)

* create-provider fix

* https://github.com/ita-social-projects/OoS-Frontend/issues/1341

* Update create-provider.component.spec.ts

* Changed short date pipe for data column #1665 (#1686)

Changed short date pipe for data column

* Fix title styling for provider information (#1696)

* added css

* added css

* Fixed message display design (#1695)

#1128

*Fixed text alignment

*Added class to lower by 1px

* [Add Assistant/admin] Not possible to create an assistant/admin (500 error) (#1694)

* update provider admin compoent

* update ProviderAdmin model

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* fix notification item aligment AC#1657 (#1701)

fixed notification item aligment

* [Filter List] - add filter option isOpenRecruitment/ isClosedRecruitment  (#1703)

* added new filter statuses

* update filter-list

* fixed

* change type statuses

* some fix

* Replaced most any types with a specific type (#1697)

* Replaced most any types with a specific type

*Added FilterList model

*Added MessageBar model

*Updated Rate model

*Replaced any types with specific type

* Updated parent.state

*Moved the fields above the ngoninit method

* Updated admin.state

*Replaced 'object' types with specific type

*Fixed incorrect return type for delete methods

*Removed unused parameters in methods

*Renamed the interface name with a name similar to the existing one

* Fixed pagination (admins, history change, provider leading to a single variable) AC#1641 (#1702)

Fixed pagination (admins, history change, providers, children leading to a single variable)

* Update Angular version to 14 (#1678)

* update version angular

* update material version

* update version angular version to 13.0

* update material version

* update angular version to 14

* update angular material to 14 version

* remove unused imports

* remove unused filter

* fixed versions

* remove -prod

* fix some tests

* fix dependencies and jest

* path fix for tests running

* fix temporary jest type-only ReferenceError

* test fix for SideMenuComponent

* config fix, test fix, build fix

* merge

* test fix: path changes to relative

* test fix: path changes to relative

* Update history-log-table.component.scss

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Anastasiia Derkach <aderk@softserveinc.com>
Co-authored-by: Taras Yaremkiv <tyare@softserveinc.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* add ESlint

* System message fix (#1709)

#1128 

* getWorkshopMessage method input parameters changed

* the message is sent from the method that calls the getWorkshopMessage method

* States update (#1707)

* Notification state updated

* Provider state updated

* Added new interface for Block/Delete ProviderAdmin

* Registration state updated

* SharedUser state updated

* Updated Application model for incoming object

* Admin state updated

* Parent state updated

* Applyed correct (green) color for approved status (#1706)

Done!

* Fixed filter margin (#1705)

Done!

* Update eslint config (#1718)

* add some ESlint rules
* add husky pre-comit

* Fixed the view for details icon link (#1719)

* Removed icon hiding

* Moved the empty result to const (#1722)

* Created EMPTY_RESULT const

* Applied EMPTY_RESULT all over the code

* Issue#1716 search response interface (#1721)

* Added  SearchResponse interface with a generic data type
* Replacing WorkshopFilterCard with SearchResponse
* Replacing ProviderCards with SearchResponse
* Replacing AllMinistryAdmins with SearchResponse
* Replacing ProvidersHistory with SearchResponse
* Replacing ProviderAdminHistory with SearchResponse
* Replacing ApplicationsHistory with SearchResponse
* Replacing WorkshopFavoriteCard with SearchResponse
* Replacing ChildCards with SearchResponse
* Replacing ApplicationCards with SearchResponse
* Replacing DirectionsFilter with SearchResponse

* move all message-bar messages to the enum (#1720)

* Created enum 'SnackbarText'

* Replaced literals with texts from enum

* [Create Workshop] fixed css, placeholder (#1726)

* fixed placeholder

* fixed all bags with placeholder email

* fixed

* [Navigation Bar] - it should not appear on the main page (#1723)

* Delete Nav Path

* added onDestroy

* Issue#1662 add functionality to change main info (#1725)

* Added the ability to add/edit info about main page

* Removed the ability to add sections when editing the main page, since there is a limit of 1 section

* Added navigate to main page after create/update mainpage info

* Update .eslintrc.json

* fixed a error when a line break from a non-windows OS was considered an error

* Update personal-cabinet (#1731)

* Fixed double getApplication request

* #1704 replaced tab with directions (#1727)

* #1704 replaced tab with directions

* #1704 added directions wrapper with tabs

* #1704 corrected routes for create direction

* Revert "#1704 corrected routes for create direction"

This reverts commit 3af9ecd71b0b6b53320a8913f64c0d9098102810.

#1704 changed directions route to directions-wrapper component

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Replaced static information in the header (#1730)

* Replaced static information in the header

* Added a field with information about the main page in MainPageState

*Embedded added field to display in the header of the main page

* Issue#1733 city confirmation (#1734)

* Fixed incorrectly working geolocation confirmation

* Fixed saving geolocation to local storage before user confirmation

* Added change of geolocation to standard (Kyiv) when clicking on the  "Change" button

* Added focus to the search input when clicking on the "Change" button

* Fixed cropped cross icon

* Removed wrapping of additional text about the city

* Reduced the width of the sliced text

* Fixed saving geolocation when location is forbidden

* Added a condition when Kyiv is already in the search, and we only need to call the list of available places without a request





Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Ministry Admin Profile] - handle personal cabinet for ministry admin (#1739)

* update ministry admin cabinet

* put condition on tab Про портал and hide tab Адміністратор міністерства

* fixed sidenav-menu

* test fix

* fixed test

* user-radius has been provided for map view (#1737)

* user-radius has been provided for map view

* Comments has been fixed

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1736 general issues map (#1744)

* Removed a command that tried to access non-existent coordinates and crashed the function

* Removed interfaces that duplicate coordinate fields from the base interface

* Renamed the coordinate fields of the base interface to the names of the same name from the query result

* Fixed removal of codeficatorid when clicking on an empty place on the map

* Fixed duplicate requests when user clicks on map

* Fixed display of a search error when an address is found

* Fixed a bug where coordinates were lost due to different field names

* Fixed infinity loading

* [Workshop/Provider details] - set current selected tab to the query param  (#1738)


Add routes for tabs in workshop page

* Fixed a directive that triggered a request event (#1750)

* Issue#1746 request without filled form (#1751)

* Added condition before sending request

* [ProviderAdmin] - add functionality to unblock Provider Admin and Ministry Admin (#1735)

* added functionality to unblock

* after review

* use enum

* fixed after review

* fix

* fix

* Fix

* Fixed mobile view of achievement-card (#1754)

Done!

* User radius has been fixed (#1757)

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* Unnecessary dispatch has been fixed (#1756)

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* #1742[Prettier] (#1755)

* prettier has been added

* Integration prettier and eslint

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* fix navigation bar for admin personal cabinet (#1766)

* [Search Bar] - removed double request triggering  on search init, fixed value saving flow to local storage (#1771)

* fixed search bar, removed triggering diuble request on serach init, fixed value saving to local storage

* Update searchbar.component.ts

* comment fix

* [Admin Tools] - Change provider status (#1758)

* added Delete Provider

* fixed paginator for provider-list

* status displayed

* added reson modal windiw for provider-list

* the correct operation of the status change buttons has been made

* fixed opean editing modal window

* some fix

* fix test faild

* imports fix

* test fix

* fix

* fix test

* fix

* Route to achievements page after creation  new achievement (#1774)

Done

* [Notifications] - handle new type of notifications  (#1781)

* added notifications

* fix

* fix style

* Issue#1759 list messages (#1776)

* Created messages component
* Created messages-card component
* Added navigation on the messages page
* Created Message model
* Created ChatRoom model
* Updated NavBarNames
* Added chat state/service/action
* Replaced mock data to json
* Changed the url address of the request for the created json file

* Issue#1768 rename application status (#1782)

* Renamed enum to more general naming
* Statuses enum replaced to statuses.ts
* Renamed applicationStatus to statuses
* Title enums replaced to status.ts
* Renamed applicationTitles variables to StatusTitles
* Renamed applicationTitlesReverse variables to StatusTitlesReverse
* Merged all identical enums into one common one
* Applied enums all over the code
* Replaced hardcoded status names

* [Refactoring] - provide error interceptor (#1792)

* create iterceptor

* create errors interceptor'

* test fix

* added method for display error msg bar

* fixed css (#1794)

* #1589 Block/Reject reason (#1632)

* done

done

* fix

* rename

* fix

* naming

* comments

comments

* test fix

* mobile size

* test fix

* import fix

* import fix for test

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* takeUntil fix (#1786)

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Provider Update] - update/create provider is not possible (#1793)

* fixed bug with button submit

* fixed condition error

* fix

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Radius configuration] - custom radius configuration (#1778)

* user-radius slider has been provided

* Warning message has been provide

* Comments has been fixed

* Update design

* Message has been provide

* fix eslint error

* Comments has been fixed

* build error has been fixed

* view handler fix

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1784 application/message card view upgrade (#1796)

* Added new mobile view for application card

* Moved common styles to full-width-card.scss file

* Added mobile view for message card

* remove lint staged (#1802)

* feature list (#1801)

* [Pagination] - items per page is missing for favorites workshops (#1803)

* fixed paginator for favorite-workshop

* test

* reformat code using prettier tool

* [Filter List, Directions Filter] - scroll to the selected category if it is preselected  (#1810)

* Solved with setTimeout

* Fixed

* removed console log

* added comment

* added comment

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1790 general styles (#1798)

* Fixed search-bar style
* Fixed workshop details
* Fixed form
* Fixed described tasks
* Fixed incorrect display of mat-chip elements on mobile view
* The blue color menu has been changed to white.
* Fixed search-bar
* Fixed filters
* Fixed social group items

* Issue#1760 messaging (#1811)

* Added chat and message components
* Updated chat state for receiving messages
* Implemented receiving messages through the service
* Finished appearance of the chat component
* Added mobile view
* Added navigation for chat
* Added the ability to go to the chat by clicking on the message card
* Updated chat state/actions/service
* Added the ability to go back from chat to messages

* [Form validation] - edit mode (#1807)

* Fixed bug with stepper for provider table

* @fix@

* fix

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Map displaying has been fixed (#1821)

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* #1704 create directions table general look 2 (#1813)

* #1704 added pulling of institution descriptions, deleted hardcoded columns, fixed comments in pr

* #1704 code formatting, added check on loading

* #1704 added again action for GetAllInstitutionsHierarchy

* #1704 comments after review

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* update URL link (#1822)

* #1690 Add filter to query string

* [Form validation] - edit mode Create-Workshop (#1823)

* added stepControls

* fixed bug with steppers from create workshop

* fix

* fix stepper from provider admin

* #1741 [Create application] Unregistered user wants to create an application to workshop (#1809)

* Unregistered user wants to create an application to workshop

* Improvements according code review

* Merge with origen-develop

* Change dialog message for adding to favorite

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Localization]  #1740 (#1824)

* recreated new branch and refcatored

* added some translation

* finished issues 1740

* fix: NG0100(Expression has changed after it was checked)

* fixed merging with map

* fixed testing

* added TODO

* Error window when try logout (#1830)

Co-authored-by: Ілля Овсянніков <50924109+Illya97@users.noreply.github.com>

* Localize (#1834)

* recreated new branch and refcatored

* added some translation

* finished issues 1740

* fix: NG0100(Expression has changed after it was checked)

* fixed merging with map

* fixed testing

* added TODO

* fixed bugs

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* #856 Add pagination for achievements (#1828)

* Add pagination for achievements

* Change order for query params

* pagination fix

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1760 sending message (#1827)

* Added file with constants of links to hubs
* Added the ability to send a message
* Implemented scrolling down after sending or receiving a message
* Added message loading when scrolling up
* SignalR service logic updated
* Replaced all mock url
* Added the ability to create chats with workshops

* Fixed bugs

* Issue#1843 Fixed translate bugs (#1845)

* Fixed translate bugs

* Added translate pipe to places where was no translation

* Fixed tests

* Issue#1835 fix page loading on refresh (#1844)

* Fixed 404 page after refresh for create-child and create-workshop forms
* Added 'new' mode to the url parameter for creating a new child instead of empty
* The names of the mode has been moved to a constant
* Removed unused fields and form controls
* Merged two routes redirecting to the same component into one

* Added action for clear chat state (#1850)

* Added action for clear chat state
* Added state clearing when leaving the chat

* [Refactoring] - header restyling, style fix, dropdown positioning fix (#1849)

* style fix

* header style fix, dropdown position fix

* Update header.component.scss

* Update header.component.scss

* notif fix

* fix comments

* Update header.component.scss

* Update header.component.scss

* Issue#1841 no result wrap (#1852)

* Template set for tabs admin-region and admin-otg

* Removed unused variable

* Implemented chain setting for HttpParams (#1853)

* #1820 create workshop info hint (#1851)

* #1820 added hint menu for workshop creation

* #1820 fixed unit test

* #1820 corrected text and width of menu

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1839 - empty cell handling (#1854)

* Added pipe to get address
* Applied a pipe to all parts of the code where an empty value can be present
* Applied pipe to other tables
* Added a way to process a phone number of 9 digits (without prefix)
* Applied PhoneTransformPipe to display phone numbers in tables

* #1804 added route to rules, change position in a list (#1857)

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>

* param fix (#1859)

* 1842 Add workshop/provider details page localization (#1858)

* Add translations for provider and workshop pages

* Add translations for header

* fix unit tests

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Create workshop hot fix (#1861)

* create-workshop hot fix

* Update working-hours.ts

* translation fix

* Update working-hours-form.component.ts

Co-authored-by: Dmytro Minochkin <dmytro.minochkin@gmail.com>

* localization fix (#1866)

* localization fix

* hot fix menu bar

* Issue#1855 upgrade notification (#1862)

* Upgraded notification view
* Added the ability to read notification groups
* Added ReadAll/DeleteById methods
* Added navigation by click on notitification group
* Added logic for adding an incoming notification

* Added redirect when changing address parameters (#1869)

* hot fix (#1871)

* Issue#1865 notifications improvements (#1868)

* Added read button blocking when notification(s) is already marked as read
* Added readAll/deleteAll buttons blocking when there are no unread notifications or no notifications
* Move the arrow to the right and added hover links
* Removed the width limit for the mobile view
* Removed the opacity of icons for the mobile view
* Added a color change when clicking on a link
* Changed the color of the arrow on hover
* Added accordion body padding

* General bug fixes (#1874)

* general create-application bug fixes

* Update workshop-details.component.html

Co-authored-by: patskal <111123815+koliapatskal@users.noreply.github.com>

* General bug fixes (#1876)

* general create-application bug fixes

* Update workshop-details.component.html

* style bug fixes

Co-authored-by: patskal <111123815+koliapatskal@users.noreply.github.com>

* Issue#1748 fix institution hierarchy logic (#1880)

* Now only the last level of the institution's hierarchy is set and saved in the final workshop.
*When selecting new institutions, the hierarchy of controls is updated
*New controls are created gradually, not all at once

* General Minor Bug Fixes (#1881)

* fix

* Update all-categories.component.html

* pagination for provider workshop (personal cabinet, details)) (#1883)

* Issue#1873 create workshop translation (#1882)

* Added translation for labels
* Added translation for validations
* Added translation for placeholders
* Added translation for form header
* Added translation for buttons text

* [ProviderAdmin/ProderDeputy] - on create/update workshop selection (#1878)

* Label was changed; Button disable without workshops

* Unnecessary flag has been removed

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Comment fixes (#1884)

* pagination for provider workshop (personal cabinet, details))

* commnets

* Update workshop-details.component.html

* [Provider Admins Page] - added pagination and filtering params (#1886)

* pagination for provider admin page

* Update provider-admin.service.spec.ts

* Button place was changed (#1885)

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* Application upgrade (#1891)

* Application Upgrade

* update applicaitons

* confirmation modals for reject/;eave message

* Update role.ts

* Update application.model.ts

* Issue get filter requests (#1889)



* Removed the FilterChange request call on events that are already intercepted by changes in the url
* Added a FilterChange call when an empty url is passed by updating the parseFilterStateQuery method and removing the empty url check
* Combined isMapView and Params subscriptions into 1 for correct query formation

* #1805 added check on index for border style (#1888)

* #1805 added check on index for border style

* #1805 changed syntax, added same logic to child-form and teacher-form

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>

* Issuer#1887 top cities (#1893)

* Added a request to get a list of top cities when the user entered less than 4 letters
* Changed the logic of assigning a city when access to the user's geolocation is blocked
* Sort by full address changed to sort by city name
* Changed condition for sorting when changing search results from the server

* Fixed result map refresh (#1895)

* Added initialization of the currentView from the url parameter
* Moved the update of the MapView in the FilterState from the child components to the parent component

* Fixed validation check for modal (#1897)

* Replaced the button disable control binding from the value of the control to its validation
* Fixed validation check for modal

* [Localization] - apply localization for Personal Cabinet (Parent/Provider view) #1867 (#1892)

* Localization has been provided for Nav, and for two tabs in personal information

* Fix comments

* comment fix

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>
Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Localization hot fix (#1903)

* Localization has been provided for Nav, and for two tabs in personal information

* Fix comments

* comment fix

* hot fix

Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>

* Localized create-child form (#1901)

* Localized form create-child
* Removed extra margin from buttons
* Fixed radio button alignment
* Added a question mark to question text
* Added a condition to disable the delete data button
* hidden button childrenAmount < 1

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue 1905 - wrong table data display (#1908)

* Added condition for displaying the table
* Added info card in case of missing data from the server

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1904 - hide warning info modal (#1909)

* Added closing of the snackbar when leaving the component

* remove redundant service

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Tech debt] - state fix  (#1914)

* admin state fix

* meta data state fix

* parent state

* removed throw error

* Update reviews.component.spec.ts

* [General tasks and bug issues fix] - routing, dirty form fix, styling (#1915)

* price style fix

* email confirmed

* remove "place" table column

* routing fix

* protected methods provided

* general style fix

* localization

* localization fix

* Update all-categories.component.spec.ts

* location typing fix

* Fixed missing form for selecting working hours (#1916)

* Now, when there is no form for selecting working hours in edit mode, a new form is added

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1640 reset data filter (#1917)

* Added filter reset button

* Added filter reset button
* Rebuilt html structure to adapt to small screens

* Added filter reset method

* Added filter reset method
* Added hover effect to reset filter button

* Update navigation-mobile-bar.component.html (#1920)

* Issue#1906 provider status display (#1918)

* Added banner component

* Added component for info banner
* Adjusted styles to match the design

* Added banner styling

* Added theme classes that are selected depending on the status
* Added interface ProviderStatus
* Added automatic setting of component styling, depending on the status
* Added enum for status headers
* Added element styles that are independent of the theme
* Replaced static data with data from enumerations

* Added close animation

* Added SCSS file for element hiding animation
* Attached animation to the banner

* Added details to status banner

* Added description to some statuses that don't get it from the server
* Added description text selection condition

* Added redirect to the page by clicking on the link

* Added input for passing link banner
* Moved edit mode activation to ngoninite to allow redirection from banner
* Fixed incorrect flag calculation for displaying redirect link

* Refactored code

* Renamed banner component
* Renamed the variable responsible for displaying the edit link

* Added OnDestroy

* Removed unused imports

* Fixed tests

* Removed unnecessary styles

* Moved the banner up a level

* Moved the banner to provider-org-info component
* Changed the way of getting the ProviderStatus from a selection from the state to getting from the parent component
* Returned the activation of the editing mode by pressing the button

* Update status-banner.component.spec.ts

* Renamed component

* Removed unnecessary enum

* Removed StatusThemes enum

* Reused an already existing enum for names of status themes

* Replaced underscore with dash in class names

* Subscription replaces

* Moved the event to the end of the argument list

* Removed ProviderStatus interface

* Removed unnecessary public variable

* Moved the hardcoded details to a separate variable

* Update provider-list.component.scss (#1922)

* Fixed wrong display data about count reviews (#1925)

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Renamed classes (#1921)

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Issue#1900 - Added manual change detection (#1913)

* Added manual change detection

* Fixed an issue where changes were not detected and the old value was used

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Update provider-status-banner.component.ts (#1923)

* Update provider-status-banner.component.ts

* Moved details to enum

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* 1825 Create new translation pipe for cases (#1896)

* Add translations pipe for cases

* fix unit test

* fix entity-checkbox-dropdown translation

* fix translation for workshops

* fix unit test

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* [Personal Info Request] - Refactor of personal info service (#1930)

* refactor of personal info service

* refactor of personal info service

* [Provider Admin] - add get provider admin by id request on provider admin update (#1931)

* ProviderAdmin: get by id

* ProviderAdmin: get by id

* Update provider-admin.ts (#1933)

* Fixed incorrect position of the pop-up menu (#1935)

* Renamed style class to be more unique
* Removed the use of ::ng-deep for this pop-up menu, moving its styles into one common file

* [Provider, Statuses, Refactoring] - provider model update, status refactoring (#1936)

* provider fix, status refactoring

* Update create-photo-form.component.spec.ts

* Update create-photo-form.component.spec.ts

* Update create-form.scss

* Update create-info-form.component.spec.ts

* general bug fixes (#1937)

* Issue#1926 update admin tools (#1934)

* Fixed header menu for ministryAdmin

* Reworked tabs for ministry admin

* Added mock data for admins table

* Added column with institution title

* Implemented columns display logic for admins table (Added a method for creating a list of displayed columns depending on the role)
* Fixed an issue where the selected tab was not saved after refreshing the page
* Updated admin data model to display in table

* Added guard for create/update admin

* Appled query params to remove "Other"

* Added todo

* Guard refactored

* Comments added

* Update ministry-admin.service.ts

* Update meta-data.state.ts

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>

* Changed the logic of reading notifications (#1940)

* Removed menu
* Implemented reading a notification on click
* Fix modal window closing after clicking on "Read all notifications" button

* Updated logic for receiving a message after sending (#1943)

* Deleted the request to the server to receive the sent message

* Issue#1945 admin applications (#1947)

* Added adminApplications component

* Added event and event handling to user state
* Added method to get all applications in applications service
* Added a component for displaying applications to the admin

* Added a search bar for applications

* Added a search bar for applications
* Extended the class of admin applications with the help of the personal cabinet component
* Minor styles changes

* Added adaptability for input

* Implemented search string filtering

* Added missing fields in the application card

* Update admin-applications.component.spec.ts

* [License Approval] - license approval process (#1939)

* license approval

* fixes

* test fix

* Update provider-org-info.component.ts

* Added listener for read messages (#1949)

* Fixed incorrect positioning of the search bar (#1953)

* Issue#1952-No-Validation-Messages (#1955)



* Added a new condition that takes into account the case where the validation text is not shown after clicking on the input without changes
* Added a method that will trigger status updates once after changing the touched property

* Fixed bug (#1966)

* Fixed bug cause: simultaneous requests to get the hierarchy, due to which the results of the highest hierarchy could come before the lower ones

* Added loading messages history (#1961)

* Added loading of message history in a chat created by workshop ID
* Updated store for receiving messages by workshop ID

* Main page styles fixes (#1973)

* Fix header menu styles

* Corrected line-height for links
* Corrected icons positions and overflow property
* Added font-family for text with default family
* Corrected lang-select width

* Updated header log-menu

* Corrected text align by changing line-height, height and padding properties
* Changed wrong font-family

* Updated search-bar margin

* Updated category item styles

* Issue#1950 statistics (#1967)

* Added statistics component
* Implemented logic for receiving statisticReports
* Added new enum for titles
* Added paginator for reports table
* Tech Debt
* Removed duplicate values from NoResultsTitle enum

* Issue#1944 chat filters (#1960)

* Implemented search by string

* Implemented filtering by workshop IDs

* Added pagination for chatrooms

* General defect fixes (#1969)

* general bug fixes

* provider list table update

* workshop provider create-form fixes

* translate pipe fixes

* Update styles.scss

* Update notifications.ts

* localixation fixes

* application bug fix

* notification license status

* snakcbar message

* Update provider-list.component.ts

* Update create-provider-admin.component.html

* Temporarily removed the upload button (#1975)

* Temporarily removed the upload button

* [Application] - Localization, new statuses (#1977)

* application localization

* Update application-card.component.html

* test fix

* comment fix

* fix navBarName and steper in UpdateProviderDeputy (#1984)

* remove star (#1985)

* LOCALIZATION (#1982)

* Update users-list.component.ts

* create-application localization

* person-card-localization

* chuiild-info-box-localization

* Update person-card.component.spec.ts

* Update person-card.component.spec.ts

* Update uk.json

* Update application-card.component.html

* translation fix

* Update navigation-tabs.scss

* child age localization

* test fix

* Update child-card.component.spec.ts

* General bug fixes (#1986)

* pagination fix for history changes

* Update notifications.ts

* async pipe

* comment fix

Co-authored-by: Ілля Овсянніков <50924109+Illya97@users.noreply.github.com>

* Parent send message from the application card (#1987)

* send message from application card

* Update application-card.component.html

* Update parent-applications.component.ts

* Update applications.component.ts

* Update en.json

* [DEFECT] - Create Direction Page (#1990)

* create direction fix

* navigation tab fix

* Update provider.service.ts

* [DEFECT] - validation hint fix (#1991)

* Add stream of touch events to form control

* js doc

* defect 1965

* Update create-form.component.ts

* Update info-form.component.html

* [LOCALIZATION] - parent view (#1994)

* placegolders

* config localization

* empty banner localization

* test fixes

* comment fix

* Update status-info-card.component.html

* [LOCALIZATION] - provider view (#1996)

* placegolders

* config localization

* empty banner localization

* test fixes

* create-provider-localization

* provider admin page

* create-provider-admins

* test fix

* fixes

* Update en.json

* [LOCALIZATION] - nav bar, admin tools, side nav bar (#1997)

* placegolders

* config localization

* empty banner localization

* test fixes

* create-provider-localization

* provider admin page

* create-provider-admins

* test fix

* Update create-provider-admin.component.spec.ts

* users list localization

* fixes

* navigation

* side nav localization

* Update header.component.html

* Update admin-tools.component.spec.ts

* test fixes

* Update uk.json

* fix tarnslation

* Middle name - non required field for models (#1999)

* middle name is not required

* non-req param

* Favorite workshops - pagination (#1998)

* pagination

* Update favorite-workshops.service.spec.ts

* Reinvitation/ Block/ Unblock of provider admins, ministry admins, provider (#2000)

* reinvitation for provider admin

* block unblcok provider admin

* Update provider-list.component.html

* block unblock provider

* Update users-list.component.ts

* Update admins.component.ts

* [Send message] - on send message action open service message for non-registered user (#2007)

* Update actions.component.html

* toggle style fix

* Admin tools - localization (#2003)

* Update admin-tools.component.html

* ADMINISTRATION

* admin tools

* Update info-edit.component.html

* edit portal info

* platform info

* users page

* users list admin tools

* provider list

* provider list

* log history

* statistics localization

* localixation

* test fix

* Update history-log-table.component.spec.ts

* Update en.json

* Update en.json

* Update en.json

* Update users-list.component.html

* provider list update

* Update en.json

* [Localization] - create-admin, admins, create-achievment, notifications (#2005)

* Update admin-tools.component.html

* ADMINISTRATION

* admin tools

* Update info-edit.component.html

* edit portal info

* platform info

* users page

* users list admin tools

* provider list

* provider list

* log history

* statistics localization

* localixation

* test fix

* Update history-log-table.component.spec.ts

* create-achievments localization

* notifications

* create-admin

* Update en.json

* Update en.json

* Update en.json

* Update users-list.component.html

* provider list update

* Update admins.component.html

* Update en.json

* Update navigation-bar.ts

* history log

* message mar localizagtion

* localization of confirmation windows

* english localization

* Update message-bar.component.spec.ts

* Update child-info-box.component.html

* error page

* localization

* empty value transform

* placeholders

* erorr fix

* test fix

* Issue#1976 pagination parameters (#1993)

* Updated paginator in app-admins component
* Updated directions pagination
* Updated provider pagination
* Updated children/parents pagination
* Updated application pagination
* Updated history-log pagination
* Updated statistic pagination
* Updated achievement pagination
* Updated details pagination
* Updated rating pagination
* Updated provide-admin pagination
* Updated messages, provider-workshops pagination
* Updated result page pagination
* Added from-size properties to filter state. This is done because pagination changes can occur from different parts of the application.
* Fixed incorrect pagination in the map component. Added a new variable that will show workshops given the current page
* Removed unused inputs and outputs
* Added constants for the number of elements per page for the paginator
* Removed paginator state
* Added redirect to 1 page when searchString are changed
* Added logic for handling the case when changing the number of elements on the page, the "from" parameter was greater than the totalAmount

* Statistic download (#2008)

* Added ability to download reports

* Fixed double download

* Renamed the constant to a more understandable name

* Hot fixes - localization fix, removed private ownership type from create provider selection (#2010)

* hot fixes

* Update reviews.component.ts

* Update city-filter.component.html

* nav bar fix

* Fixed bug with city switching (#2011)

* Fixed a bug with city switching when the filters did not put the coordinates of the new city

* Issue#1979 localize calendar (#2023)

* Added localization change for datepicker

* Added remembering the selected localization

* Added logic for localization selection when entering the application

* Fixed tests

* Fixed comments

* Moved language detection logic from module to component
* Returned the registration of Ukrainian localization

* Fixed tests

* Issue#2018-Fixed property access for undefined variable (#2022)


Fixed a bug when a property was accessed on a undefined object

* Fixed assignment undefined to null
* Updated the condition for adding the ispParent parameter
* Removed unused method arguments

* add autoassign and change CSP (#2025)

* Fixed localization bugs (#2026)

* Fixed achievement subheader translation
* Fixed missing titles and label translation

* Added parameter to get parent in list with children (#2027)

* Fix (#2030)

* Fixed the wrong path when in the menu of a blocked provider, the button was labeled "block" and the unblocked one was "unblock"

* #1890 directions table update  (#2028)

* #1890 added directions column, and delete/edit buttons

* #1890 corrected styles for direction button

* #1890 fixed formatting issues, deleted useless function and comment

---------

Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>

* [Issue#2031] fixed error on CONFIRM_EDITING button click (#2032)

Co-authored-by: Viktor Patraboi <vpatr@softserveinc.com>

* [Issue#2015] updated create child endpoint (#2033)

Co-authored-by: Viktor Patraboi <vpatr@softserveinc.com>

* History logs switch localization languages (#2029)



* Fixed incorrect attribute name, on which the choice of translation depended
* Fixed a bug where we tried to access the request response property before getting the response itself
* Moved subscriptions to observables to the ngOnInit method, removing the use of take(1) operators

* Issue#2021 admin invitation same lavel (#2034)

* actions and sirting fix

* character fix

---------

Co-authored-by: Olha_Hlova <ohlov@softserveinc.com>

* search adjustment fix (#2036)

Co-authored-by: Olha_Hlova <ohlov@softserveinc.com>

* Issue#2013 managed workshops lists (#2035)


* Updated service: added a method to get a list of workshops for the admin provider
*  Added a new action and its processing
* Added a condition for choosing how to receive workshops depending on the user's role
* Now the role of the providerDeputy will receive the list of workshops and applications in the same way as the role of the provider
* Added the ability to mark select elements from the parent component. This is done by adding the ability to pass the FormControl via Input and manipulate the value via the parent component.
* Updated the data model of the providerAdmin for the changed model from the server
* Fixed a bug when sending null to OnUpdateProviderAdminSuccess, where they tried to access its properties. This happened because we expected the request to return the providerAdmin, however it does not return anything
* Added logic that is responsible for marking all workshops that are assigned to the providerAdmin
* Defined the type of variables that were declared without specifying a type
* Variable and method access modifiers defined
* Removed one unnecessary variable because it holds a duplicate value

* Feature/2014 add region admin (#2038)

* #2014 region admin CRUD added


---------

Co-authored-by: Viktor Patraboi <vpatr@softserveinc.com>

* update api routes (#2043)

* Issue#2040 no redirect on notification click (#2042)


* Updated redirect function to handle single notifications
* Updated styles for notifications. Now the styles for the notification header and its body do not overlap
* Added styles and an icon to the body of a single notification to demonstrate the ability to redirect on click

* Optimized condition
* Added access modificators

* Fixed favorites pagination (#2041)

* Fixed pagination

* Fixed a bug when switching to the next page and switching the number per page did not work

* Added modificators for fields and methods

* [#2039] fixed workshops filter request params (#2044)

Co-authored-by: Viktor Patraboi <vpatr@softserveinc.com>

* Child api refactor (#2048)

* Updated child endpoints

* Added access modificators

* Updating the child model

* Updated the child model for the updated endpoints put ta post

* Issue#1978 application limit (#2046)


* Updated interceptor operation, now after processing an error it rolls it on, instead of creating a new error
* The error handling logic has been changed. Previously, the error type was determined by the message text that the interceptor transmitted. Now the error is determined by its status.
* The message-bar styles have been updated. The text is now placed in the body of the notification

* Issue#1902 reading notification (#2049)

* Updated logic for processing and reading notifications

* Added reading of application notifications when redirecting to the applications page

* Issue#2050 refactor history of changes page (#2051)

* Deleted unnecessary data on the history-log page
* Replaced the two inputs for entering dates with one
* Added "All filters" option for select
* Added default value for the date control
* Added access modifiers

* update logo (#2052)

* Localization fixed (#2054)

* Added missed path
* Added translate pipe

* add release config (#2056)

* add release config

* fix naming

* Update angular.json

---------

Co-authored-by: Oleksandra Lytvynets <alitvinets7@gmail.com>
Co-authored-by: Ілля Овсянніков <50924109+Illya97@users.noreply.github.com>
Co-authored-by: Pavlo Ostrozhynskyi <47858505+Pabloostr@users.noreply.github.com>
Co-authored-by: patskal <111123815+koliapatskal@users.noreply.github.com>
Co-authored-by: Yuliia <57331621+sivxkxn@users.noreply.github.com>
Co-authored-by: LeraKornienko <96778768+LeraKornienko@users.noreply.github.com>
Co-authored-by: anastasiiaderkach1996 <56758892+anastasiiaderkach1996@users.noreply.github.com>
Co-authored-by: Anastasiia Derkach <aderk@softserveinc.com>
Co-authored-by: friranger1 <65720979+friranger1@users.noreply.github.com>
Co-authored-by: Taras Yaremkiv <ytaras@gmail.com>
Co-authored-by: Taras Yaremkiv <tyare@softserveinc.com>
Co-authored-by: Kolia <patskalWork@gmail.com>
Co-authored-by: nazarstig <45310972+nazarstig@users.noreply.github.com>
Co-authored-by: Nazarii Ivasyshyn <nivasy@softserveinc.com>
Co-authored-by: Mykhailo Khrystenko <90037530+khrMykhailo@users.noreply.github.com>
Co-authored-by: Mykhailo Khrystenko <khrystenko.m.y@gmail.com>
Co-authored-by: Prettier utility <prettier@github.com>
Co-authored-by: inga-lekhman <37378854+inga-lekhman@users.noreply.github.com>
Co-authored-by: Taras Slovak <43480992+Taras-Slovak@users.noreply.github.com>
Co-authored-by: okedo <31219207+okedo@users.noreply.github.com>
Co-authored-by: Viktor Patraboi <vpatr@softserveinc.com>
Co-authored-by: Olha Hlova <55574080+OlyaHlova@users.noreply.github.com>
Co-authored-by: Olha_Hlova <ohlov@softserveinc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants